Skip to content

[SSPROD-48724] CFT template for VM Workload Scanning #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 12, 2024
Merged

[SSPROD-48724] CFT template for VM Workload Scanning #139

merged 7 commits into from
Dec 12, 2024

Conversation

@miguelpais
Copy link
Collaborator

No description provided.

@miguelpais miguelpais requested review from a team as code owners December 9, 2024 15:42
@miguelpais miguelpais self-assigned this Dec 9, 2024
cgeers
cgeers previously requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@cgeers cgeers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logical permutations of org and lambda enabled seem duplicative and unnecessarily brittle.

Instead, I'd advocate using an IAM::RolePolicy to conditionally apply polices when needed, rather than duplicating entire resource blocks.

@miguelpais
Copy link
Collaborator Author

The logical permutations of org and lambda enabled seem duplicative and necessarily brittle.

Instead, I'd advocate using an IAM::RolePolicy to conditionally apply polices when needed, rather than duplicating entire resource blocks.

The logical permutations of org and lambda enabled seem duplicative and unnecessarily brittle.

Instead, I'd advocate using an IAM::RolePolicy to conditionally apply polices when needed, rather than duplicating entire resource blocks.

Handled, please re-check.

@miguelpais miguelpais requested a review from cgeers December 10, 2024 08:59
cgeers
cgeers approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@cgeers cgeers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

ravinadhruve10
ravinadhruve10 reviewed Dec 10, 2024
View reviewed changes
ravinadhruve10
ravinadhruve10 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @miguelpais !

@miguelpais miguelpais merged commit f1e5366 into main Dec 12, 2024
2 of 3 checks passed
@miguelpais miguelpais deleted the ssprod-48724-cft-for-vm-workload-scanning-aws branch December 12, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 approved these changes

+1 more reviewer

@cgeers cgeers cgeers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miguelpais miguelpais

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miguelpais @cgeers @ravinadhruve10