Skip to content

fix(linting): Specying older version for linting #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2024
Merged

fix(linting): Specying older version for linting #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a922a20
Trying to see if linting goes away
miguelpais Dec 14, 2024
942feec
trying again
miguelpais Dec 14, 2024
7a14ecb
dummy change to force linting
miguelpais Dec 14, 2024
c5de813
comment from ravhina
miguelpais Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci-modules.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ jobs:

- name: cfn-lint
uses: scottbrenner/cfn-lint-action@v2
with:
version: 1.18.3

- name: Lint
working-directory: modules
run: make lint

validate:
name: Validate Templates
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion modules/foundational.cft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ Resources:

Outputs:
ConfigPostureRoleARN:
Description: ARN of the config posture role
Description: ARN of the role for config posture
Value:
Fn::Sub: ${ConfigPostureRole.Arn}
OnboardingRoleARN:
Expand Down
Loading