feat(event-bridge): change cft to create api dest (SSPROD-53940)

[matteopasa]

This pull request introduces significant changes to the modules/log_ingestion.events.cft.yaml file, focusing on replacing the TargetEventBusARN parameter with new parameters related to API authentication and ingestion for Sysdig Secure. The main changes include adding new parameters (ApiKey, IngestionUrl, RateLimit), updating resource definitions, and modifying IAM policies.

Parameter Updates:

• Added new parameters: ApiKey, IngestionUrl, and RateLimit to replace TargetEventBusARN for API authentication and ingestion. [1] [2] [3]

Resource Definition Updates:

• Updated the Resources section to include new resources EventBridgeConnection and EventBridgeApiDestination for API destinations. [1] [2]

IAM Policy Updates:

• Modified IAM policies to allow actions related to events:InvokeApiDestination, events:DescribeApiDestination, and events:DescribeConnection. [1] [2]

Parameter Key Updates:

• Updated parameter keys in various resource definitions to use ApiKey, IngestionUrl, and RateLimit instead of TargetEventBusARN. [1] [2] [3]

EventBridge Rule Updates:

• Modified the EventBridgeRule resource to use the new API destination and updated the associated properties. [1] [2]

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

modules/log_ingestion.events.cft.yaml:498

• The substitution variable 'EventBridgeRoleName' is used but not defined elsewhere in the template. Consider replacing it with the existing variable 'Name' or defining 'EventBridgeRoleName' explicitly.

- !Sub "arn:aws:events:*:*:api-destination/${EventBridgeRoleName}-destination/*"

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

modules/log_ingestion.events.cft.yaml:335

• [nitpick] Consider standardizing the description terminology for 'IngestionUrl' across the file (e.g., using either 'ingestion URL' or 'API endpoint URL') to maintain consistency.

Description: Target endpoint URL for the API destination