feat(cloudlogs): add cross account support#150
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
modules/log_ingestion.s3.cft.yaml:148
- [nitpick] Consider updating 'CloudlogsS3Access' to 'CloudLogsS3Access' for consistent capitalization across the template.
- Sid: "CloudlogsS3Access"
ravinadhruve10
left a comment
ravinadhruve10
left a comment
There was a problem hiding this comment.
Mainly comments around using soon-to-be-deprecated parameter.
| default: Bucket Account ID | ||
| TopicAccountId: | ||
| default: SNS Topic Account ID | ||
| OrganizationalUnitIds: |
There was a problem hiding this comment.
With include/exclude support for AWS, we want to avoid using this parameter since it will be deprecated soon anyway.
Could you please update this to use the new parameters instead as this? we should start adding org install support to cloud-logs using the new params.
There was a problem hiding this comment.
Approving this for now. This support for all new installs with new include/exclude based parameters can be added in a separate PR.
| default: Bucket Account ID | ||
| TopicAccountId: | ||
| default: SNS Topic Account ID | ||
| OrganizationalUnitIds: |
There was a problem hiding this comment.
Approving this for now. This support for all new installs with new include/exclude based parameters can be added in a separate PR.
4 participants
Support cross-region and cross-accounts deployments for Cloud Logs integration
Changes:
This allows the module to work correctly when the S3 bucket and SNS topic are in different regions