feat(modular): add modular support for cdr/ciem #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jose-pablo-camacho We should rename the integration to |
I have changed the name from |
|
Left a few comments, you will also need to rebase & address some merge conflicts based on latest master. |
haresh-suresh
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-46143
This is a draft PR for now, it contains the refactor for GCP modular onboarding specifically for CDR and CIEM.
It is important to notice that this will be cleaned up until the Onboarding + CSPM terraform snippets are ready, for now
ignore all the commented sections, the uncommented sections are the ones that will be part of the new snippets.