Skip to content

feat(vm): add vm modular support #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Sep 17, 2024
Merged

feat(vm): add vm modular support #39

merged 37 commits into from
Sep 17, 2024

Conversation

@jose-pablo-camacho
Copy link
Contributor

jose-pablo-camacho and others added 29 commits September 5, 2024 14:45
@jose-pablo-camacho
feat(modular): add modular support for cdr/ciem
5862307
@jose-pablo-camacho
feat(modular): add modular support for cdr/ciem
285d3ab
@jose-pablo-camacho
feat(modular): add modular support for cdr/ciem
86f419c
@jose-pablo-camacho
feat(modular): add modular support for cdr/ciem
5ff322f
@jose-pablo-camacho
feat(modular): add modular support for cdr/ciem
519d695
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem
72b6314
@jose-pablo-camacho
Merge branch 'master' into feat/modular/cdr-ciem
f7be89a
@haresh-suresh @jose-pablo-camacho
adding modular onboarding module
e51c02d
@haresh-suresh @jose-pablo-camacho
fix var refns
80b782a
@haresh-suresh @jose-pablo-camacho
adding modular onboarding example
6795442
@haresh-suresh @jose-pablo-camacho
adding config posture module for modular onboarding
7a07625
@haresh-suresh @jose-pablo-camacho
updating README
5581c6a
@haresh-suresh @jose-pablo-camacho
fix role naming & version metadata
4abc7b2
@haresh-suresh @jose-pablo-camacho
updating examples for onboarding & cspm org
b4d8e07
@haresh-suresh @jose-pablo-camacho
cleanup foundational READMEs
e9a212d
@haresh-suresh @jose-pablo-camacho
use external_id datasource
2885ccc
@haresh-suresh @jose-pablo-camacho
update README
628a2d6
@haresh-suresh @jose-pablo-camacho
remove mgmt_group_ids in cspm module
211a8de
@haresh-suresh @jose-pablo-camacho
bump sysdig provider version to be consistent & have latest datasources
ec938f0
@haresh-suresh @jose-pablo-camacho
updating examples
b37fe73
@haresh-suresh @jose-pablo-camacho
update example
99b4062
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem, reb…
af3f570 
…ase and cleanup
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem, reb…
70263ab 
…ase and cleanup
@haresh-suresh @jose-pablo-camacho
add explicit dependency
dfd45da
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem, reb…
e834d16 
…ase and cleanup
@jose-pablo-camacho
Merge branch 'master' into feat/modular/cdr-ciem
9acee0d
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem, reb…
72aafe0 
…ase and cleanup
@jose-pablo-camacho
feat(modular): address feedback for modular support for cdr/ciem, reb…
4d60c2d 
…ase and cleanup
@jose-pablo-camacho
feat(vm): add vm modular support
869630a
@jose-pablo-camacho jose-pablo-camacho marked this pull request as ready for review September 13, 2024 22:39
@jose-pablo-camacho jose-pablo-camacho requested a review from a team as a code owner September 13, 2024 22:39
ravinadhruve10
ravinadhruve10 reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh reviewed Sep 17, 2024
View reviewed changes
haresh-suresh
haresh-suresh approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@haresh-suresh haresh-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets remove the accidental update on config-posture README

@jose-pablo-camacho jose-pablo-camacho merged commit d8e8da8 into master Sep 17, 2024
8 checks passed
@jose-pablo-camacho jose-pablo-camacho deleted the feat/modular/vm branch September 17, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ravinadhruve10 ravinadhruve10 ravinadhruve10 left review comments

@haresh-suresh haresh-suresh haresh-suresh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jose-pablo-camacho @haresh-suresh @ravinadhruve10