enhance(modular): add unique naming for ingestion_topic name #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkraemer-sysdig
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
google_service_account_iam_bindingto be agoogle_service_account_iam_memberbecause IAM binding is authoritative for a given role, this means since we're applying a new member over the same roleroles/iam.workloadIdentityUserit will be overwriting the member specified in the other IAM member within the same file. This will keep consistency and also avoid issues seen during validation.Doc ref: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/google_service_account_iam