fix(routing-key): enable routing key generation in a deterministic way #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgeers
reviewed
Oct 15, 2024
jose-pablo-camacho
changed the title
cgeers
reviewed
Oct 16, 2024
cgeers
approved these changes
Oct 16, 2024
cgeers
reviewed
Oct 16, 2024
ravinadhruve10
approved these changes
Oct 17, 2024
jacalvo
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://sysdig.atlassian.net/browse/SSPROD-47456
This PR changes how the
routingKeyvalue can be generated in a deterministic way based off thecustomerIDandprojectIDusing the uuidv5 function within Terraform. This will help avoiding to update the routing key to be updated every time and also avoid leaking resources.It's always going to call the
UpsertRoutingKeymethod when storing the component withincloudauthservice.Note:I was able to run a TFAPPLYand thenRE-APPLYit without updating theroutingKeyand without the subsequent errors.