Skip to content

Conversation

@jose-pablo-camacho
Copy link
Contributor

@jose-pablo-camacho jose-pablo-camacho commented Jan 15, 2025

@jose-pablo-camacho jose-pablo-camacho requested a review from a team as a code owner January 15, 2025 18:46
@haresh-suresh haresh-suresh self-requested a review January 15, 2025 23:03
Copy link
Contributor

@haresh-suresh haresh-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Great work 👏

One nit I have is : lets update the OCI provider stanza to reflect the config_file_profile = "DEFAULT" instead of the fingerprint in all our examples.

@jose-pablo-camacho jose-pablo-camacho merged commit 91de463 into main Jan 17, 2025
@jose-pablo-camacho jose-pablo-camacho deleted the oci/cspm/create-user branch January 17, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants