Skip to content

fix(notification-channels) Update the terraform tests to account for the notification channel url validation #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fix(notification-channels) Update the terraform tests to account for the notification channel url validation #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sysdig/data_source_sysdig_monitor_notification_channel_msteams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func monitorNotificationChannelMSTeams(name string) string {
return fmt.Sprintf(`
resource "sysdig_monitor_notification_channel_msteams" "nc_msteams" {
name = "%s"
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
}

data "sysdig_monitor_notification_channel_msteams" "nc_msteams" {
Expand Down
2 changes: 1 addition & 1 deletion sysdig/data_source_sysdig_monitor_notification_channel_slack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func monitorNotificationChannelSlack(name string) string {
return fmt.Sprintf(`
resource "sysdig_monitor_notification_channel_slack" "nc_slack" {
name = "%s"
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
show_section_runbook_links = false
show_section_event_details = false
Expand Down
2 changes: 1 addition & 1 deletion sysdig/data_source_sysdig_secure_notification_channel_msteams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func secureNotificationChannelMSTeams(name string) string {
return fmt.Sprintf(`
resource "sysdig_secure_notification_channel_msteams" "nc_msteams" {
name = "%s"
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
template_version = "v2"
}

Expand Down
2 changes: 1 addition & 1 deletion sysdig/data_source_sysdig_secure_notification_channel_slack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func secureNotificationChannelSlack(name string) string {
return fmt.Sprintf(`
resource "sysdig_secure_notification_channel_slack" "nc_slack" {
name = "%s"
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
template_version = "v2"
}
Expand Down
4 changes: 2 additions & 2 deletions sysdig/resource_sysdig_monitor_notification_channel_msteams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func monitorNotificationChannelMSTeamsWithName(name string) string {
resource "sysdig_monitor_notification_channel_msteams" "sample-msteams1" {
name = "Example Channel %s - MS Teams"
enabled = true
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
notify_when_ok = true
notify_when_resolved = true
}`, name)
Expand All @@ -61,7 +61,7 @@ resource "sysdig_monitor_notification_channel_msteams" "sample-msteams2" {
name = "Example Channel %s - MS Teams"
share_with_current_team = true
enabled = true
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
notify_when_ok = true
notify_when_resolved = true
}`, name)
Expand Down
6 changes: 3 additions & 3 deletions sysdig/resource_sysdig_monitor_notification_channel_slack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func monitorNotificationChannelSlackWithName(name string) string {
resource "sysdig_monitor_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand All @@ -65,7 +65,7 @@ resource "sysdig_monitor_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
share_with_current_team = true
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand All @@ -77,7 +77,7 @@ func monitorNotificationChannelSlackSharedWithShowSection(name string) string {
resource "sysdig_monitor_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand Down
6 changes: 3 additions & 3 deletions sysdig/resource_sysdig_secure_notification_channel_msteams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func secureNotificationChannelMSTeamsWithName(name string) string {
resource "sysdig_secure_notification_channel_msteams" "sample-msteams" {
name = "Example Channel %s - MS Teams"
enabled = true
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
notify_when_ok = true
notify_when_resolved = true
}`, name)
Expand All @@ -69,7 +69,7 @@ resource "sysdig_secure_notification_channel_msteams" "sample-msteams" {
name = "Example Channel %s - MS Teams"
share_with_current_team = true
enabled = true
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
notify_when_ok = true
notify_when_resolved = true
}`, name)
Expand All @@ -80,7 +80,7 @@ func secureNotificationChannelMSTeamsWithNameAndTemplateVersion(name, version st
resource "sysdig_secure_notification_channel_msteams" "sample-msteams" {
name = "Example Channel %s - MS Teams"
enabled = true
url = "https://hooks.msteams.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://sysdig.webhook.office.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
notify_when_ok = true
notify_when_resolved = true
template_version = "%s"
Expand Down
6 changes: 3 additions & 3 deletions sysdig/resource_sysdig_secure_notification_channel_slack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func secureNotificationChannelSlackWithName(name string) string {
resource "sysdig_secure_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand All @@ -70,7 +70,7 @@ resource "sysdig_secure_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
share_with_current_team = true
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand All @@ -82,7 +82,7 @@ func secureNotificationChannelSlackWithNameAndTemplateVersion(name, version stri
resource "sysdig_secure_notification_channel_slack" "sample-slack" {
name = "Example Channel %s - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = true
notify_when_resolved = true
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/monitor_notification_channel_slack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Creates a Sysdig Monitor Notification Channel of type Slack.
resource "sysdig_monitor_notification_channel_slack" "sample-slack" {
name = "Example Channel - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = false
notify_when_resolved = false
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/secure_notification_channel_slack.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Creates a Sysdig Secure Notification Channel of type Slack.
resource "sysdig_secure_notification_channel_slack" "sample-slack" {
name = "Example Channel - Slack"
enabled = true
url = "https://hooks.slack.cwom/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
url = "https://hooks.slack.com/services/XXXXXXXXX/XXXXXXXXX/XXXXXXXXXXXXXXXXXXXXXXXX"
channel = "#sysdig"
notify_when_ok = false
notify_when_resolved = false
Expand Down
Loading