Skip to content

fix(docs): update wrong titles in doc and update to more recent doc URLs #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

fix(docs): update wrong titles in doc and update to more recent doc URLs #622

merged 3 commits into from
Jul 23, 2025

Conversation

@airadier
Copy link
Collaborator

@airadier airadier commented Mar 26, 2025 •
edited
Loading

  • Fix wrong doc title and example for IBM Function notification data source
  • Fix wrong title and update URL for Fargate workload agent
  • Fix document for secure_posture_policy data source

@airadier airadier changed the title fix(monitor-data-source): wrong doc title and example for IBM Function notification fix(docs): update wrong titles in doc and update to more recent doc URLs Mar 26, 2025
francesco-racciatti
francesco-racciatti previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@francesco-racciatti francesco-racciatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the fargate part
Thanks for addressing this!

pgcrooks-sysdig
pgcrooks-sysdig previously approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fargate LGTM!

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale This has become stale due to inactivity label Jul 4, 2025
@airadier airadier removed the stale This has become stale due to inactivity label Jul 7, 2025
@airadier airadier force-pushed the fix-ibm-function-data-source branch from 04e2cc2 to d525236 Compare July 7, 2025 16:16
@airadier airadier enabled auto-merge (squash) July 7, 2025 17:08
pgcrooks-sysdig
pgcrooks-sysdig approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@pgcrooks-sysdig pgcrooks-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airadier airadier merged commit 2de87b4 into master Jul 23, 2025
39 of 40 checks passed
@airadier airadier deleted the fix-ibm-function-data-source branch July 23, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tembleking tembleking tembleking approved these changes

@pgcrooks-sysdig pgcrooks-sysdig pgcrooks-sysdig approved these changes

@michelevergnano michelevergnano Awaiting requested review from michelevergnano

@dkutsanov dkutsanov Awaiting requested review from dkutsanov

@antonio-cuomo antonio-cuomo Awaiting requested review from antonio-cuomo

@dbonf dbonf Awaiting requested review from dbonf

@marojor marojor Awaiting requested review from marojor marojor is a code owner

@gnosek gnosek Awaiting requested review from gnosek gnosek is a code owner

@kmvachhani kmvachhani Awaiting requested review from kmvachhani

@rosenbloomb-sysdig rosenbloomb-sysdig Awaiting requested review from rosenbloomb-sysdig rosenbloomb-sysdig is a code owner

@ombellare ombellare Awaiting requested review from ombellare ombellare is a code owner

@miguelgordo miguelgordo Awaiting requested review from miguelgordo

@ivanlysiuk-sysdig ivanlysiuk-sysdig Awaiting requested review from ivanlysiuk-sysdig ivanlysiuk-sysdig is a code owner

@daniel-almeida daniel-almeida Awaiting requested review from daniel-almeida daniel-almeida is a code owner

@jbainbridgesysdig jbainbridgesysdig Awaiting requested review from jbainbridgesysdig jbainbridgesysdig is a code owner

@chen-shmilovich-sysdig chen-shmilovich-sysdig Awaiting requested review from chen-shmilovich-sysdig

@francesco-racciatti francesco-racciatti Awaiting requested review from francesco-racciatti francesco-racciatti is a code owner

@mateobur mateobur Awaiting requested review from mateobur mateobur is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@airadier @tembleking @francesco-racciatti @pgcrooks-sysdig