Skip to content

fix(secure-policies): Add retry logic for 409 error #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 7, 2025
Merged

fix(secure-policies): Add retry logic for 409 error #668

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d06416
Added Claude Code suggestion for retries on 409
rosenbloomb-sysdig Oct 6, 2025
05b3b59
Fixed syntax errors
rosenbloomb-sysdig Oct 6, 2025
43db882
Remove unneeded code
rosenbloomb-sysdig Oct 6, 2025
2181922
Implement retry logic in client code
rosenbloomb-sysdig Oct 6, 2025
975979c
Cleanup code
rosenbloomb-sysdig Oct 6, 2025
afef79d
Add exponential backoff
rosenbloomb-sysdig Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions sysdig/internal/client/v2/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,23 @@ func newHTTPClient(cfg *config) *http.Client {
transport := http.DefaultTransport.(*http.Transport).Clone()
transport.TLSClientConfig = &tls.Config{InsecureSkipVerify: cfg.insecure}
httpClient.HTTPClient = &http.Client{Transport: transport}

// Configure retry logic for 409 Conflict errors
httpClient.RetryMax = 5
httpClient.CheckRetry = func(ctx context.Context, resp *http.Response, err error) (bool, error) {
// Use default retry logic for connection errors and 5xx
shouldRetry, checkErr := retryablehttp.DefaultRetryPolicy(ctx, resp, err)
if shouldRetry || checkErr != nil {
return shouldRetry, checkErr
}

// Additionally retry on 409 Conflict
if resp != nil && resp.StatusCode == http.StatusConflict {
return true, nil
}

return false, nil
}

return httpClient.StandardClient()
}
Loading