Skip to content

Commit 411ff22

Browse files
authored
🌱 Use logger instead of by to avoid e2e test failure. (#1602)
1 parent 5b4892c commit 411ff22

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

test/e2e/basic_baremetal_test.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
2929
"sigs.k8s.io/cluster-api/util/conditions"
3030
"sigs.k8s.io/controller-runtime/pkg/client"
31+
"sigs.k8s.io/controller-runtime/pkg/log"
3132

3233
infrav1 "github.com/syself/cluster-api-provider-hetzner/api/v1beta1"
3334
)
@@ -41,7 +42,8 @@ func logBareMetalHostStatusContinously(ctx context.Context, c client.Client) {
4142
case <-t:
4243
err := logBareMetalHostStatus(ctx, c)
4344
if err != nil {
44-
By(fmt.Sprintf("Error logging BareMetalHost status: %v", err))
45+
log := log.FromContext(ctx)
46+
log.Info("Error logging BareMetalHost status", "error", err)
4547
}
4648
}
4749
}

test/e2e/caph.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
"sigs.k8s.io/cluster-api/util"
3737
"sigs.k8s.io/cluster-api/util/conditions"
3838
"sigs.k8s.io/controller-runtime/pkg/client"
39+
"sigs.k8s.io/controller-runtime/pkg/log"
3940

4041
infrav1 "github.com/syself/cluster-api-provider-hetzner/api/v1beta1"
4142
)
@@ -61,7 +62,8 @@ func logHCloudMachineStatusContinously(ctx context.Context, c client.Client) {
6162
case <-t:
6263
err := logHCloudMachineStatus(ctx, c)
6364
if err != nil {
64-
ginkgo.By(fmt.Sprintf("Error logging HCloudMachine status: %v", err))
65+
logger := log.FromContext(ctx)
66+
logger.Info("Error logging HCloudMachine status", "error", err)
6567
}
6668
}
6769
}

0 commit comments

Comments
 (0)