🌱 Before using the ssh Rescue Client, ensure the rescue system is active. Log reboot events #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/L
guettli
commented
May 7, 2025
github-actions
bot
added
size/M
janiskemper
previously approved these changes
May 7, 2025
…ore-pre-provision-command
…/check-hostname-before-pre-provision-command
github-actions
bot
added
size/L
guettli
changed the title
janiskemper
requested changes
May 12, 2025
…ore-pre-provision-command
janiskemper
reviewed
May 13, 2025
github-actions
bot
added
size/M
janiskemper
reviewed
May 14, 2025
janiskemper
previously approved these changes
May 14, 2025
|
Strange error in e2e test:
136.243.69.167 is severID=1670788 162.55.157.123 is controlPlaneEndpoint and apiServerEndpoint in KubeadmConfig |
…ore-pre-provision-command
janiskemper
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before using the ssh Rescue Client, ensure the rescue system is active.
This uses ssh not an API. So rate-limit is not an issue.
It is better to double-check that.
Additionally, Events created when rebooting machines will be written to the logs, so that debugging failing e2e is easier. Unfortunately this means
ctxneeds to be added to a lot of functions.