🌱 Use IgnoreNotFound when fetching related objects in controllers#1906
Draft
abdullah599 wants to merge 2 commits intov1.1.xfrom
Draft
🌱 Use IgnoreNotFound when fetching related objects in controllers#1906abdullah599 wants to merge 2 commits intov1.1.xfrom
abdullah599 wants to merge 2 commits intov1.1.xfrom
Conversation
github-actions
bot
added
size/S
| if err != nil { | ||
| return reconcile.Result{}, client.IgnoreNotFound(err) | ||
| } | ||
| if cluster == nil { |
Contributor
There was a problem hiding this comment.
I think if cluster == nil i.e. the owner ref is not set yet, even then we can return without reque because once owner ref is set (i.e. there is an update) , the object will be reconciled again.
Similar at other places
- GetOwnerMachine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uses
client.IgnoreNotFoundwhen fetching related objects (Machine, Cluster, HetznerCluster, HetznerBareMetalMachine) across all controllers. This prevents repeated reconciliation loops when related objects are missing due to dangling references (the controller cannot fix these inconsistencies, so it should stop reconciling instead of retrying indefinitely).Which issue(s) this PR fixes:
Fixes #1894
Special notes for your reviewer:
Base branch is
v1.1.x.TODOs: