You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades futures-lite to match the PR for async-io-mini.
Open Questions
This is a breaking API change. Therefore, at least edge-net would need to be updated to 0.8.0 and edge-nal-std to 0.3.0. However, the latter would then be inconsistent with the versions of the remaining crates.
Upgrades futures-lite to match the PR for async-io-mini.
Open Questions
This is a breaking API change. Therefore, at least edge-net would need to be updated to 0.8.0 and edge-nal-std to 0.3.0. However, the latter would then be inconsistent with the versions of the remaining crates.
As explained here this is not a breaking change, so I'll merge your PR as-is.
Also, once I publish the new version of edge-net on crates.io, most sub-crates' versions would be raised backwards-incompatibly anyway, due to other breaking changes, which had accumulated since the last crates.io release.
Update: actually you are right, that futures-lite is used as a regular dependency specifically in edge-nal-std, even if this is still an internal detail a bit rather than something which is re-exposed as an API (we just use futures_lite::io::AsyncReadExt/AsyncWriteExt).
Oh well. We'll just raise the version of edge-nal-std as well.
Actually... edge-nal-std specifically is not released even once yet on crates.io, so whether we'll raise its version (as we did for `async-io-mini) or not - I don't think it matters.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
futures-liteto match the PR forasync-io-mini.Open Questions
edge-netwould need to be updated to0.8.0andedge-nal-stdto0.3.0. However, the latter would then be inconsistent with the versions of the remaining crates.