Skip to content

Conversation

ivmarkov
Copy link
Collaborator

(Not immediately as we might have to wait until esp-wifi gets it as well.)

@MabezDev
Copy link

Not immediately as we might have to wait until esp-wifi gets it as well.

What do you need on the esp-wifi side? embassy-net-driver didn't change so you should be able to use [email protected] with the currently released esp-wifi... in theory :D, let me know if that's not the case.

@ivmarkov
Copy link
Collaborator Author

Not immediately as we might have to wait until esp-wifi gets it as well.

What do you need on the esp-wifi side? embassy-net-driver didn't change so you should be able to use [email protected] with the currently released esp-wifi... in theory :D, let me know if that's not the case.

Ah right - you are only depending on the -driver thing. Even better then!

@lu-zero
Copy link
Contributor

lu-zero commented Nov 28, 2024

Current esp-wifi uses smoltcp-0.11, from the user-side you want to have everything on the same smoltcp version.

@MabezDev
Copy link

True, but it doesn't stop you using embassy-net because it uses its own device trait. I opened an upstream issue smoltcp to do the same btw: smoltcp-rs/smoltcp#1010

@lu-zero
Copy link
Contributor

lu-zero commented Nov 28, 2024

Yes, it is just mildly annoying since you have to put in the configuration for smoltcp twice like I did in wot-rust/wot-esp-hal-demo#14

@ivmarkov ivmarkov force-pushed the embassy-net-05 branch 2 times, most recently from 38d82bd to 289421a Compare December 11, 2024 13:35
lu-zero and others added 3 commits December 11, 2024 13:43
* Adapt changes to upstream embassy-net

* Remove leftover imports

And use the now release embassy-net.

* Implement Readable for embassy-net 0.5

* Simplify the internal helpers

---------

Co-authored-by: Shaw Drastin <[email protected]>
@lu-zero
Copy link
Contributor

lu-zero commented Dec 23, 2024

Had been a while, do you have time to land it and cut a release? Doesn't look like we'll have an esp-wifi update much soon ^^;

@ivmarkov
Copy link
Collaborator Author

Had been a while, do you have time to land it and cut a release? Doesn't look like we'll have an esp-wifi update much soon ^^;

Is it working fine for you in the meantime?
Don't want to cut a release which does not work...

@lu-zero
Copy link
Contributor

lu-zero commented Dec 23, 2024

I had a branch for the mdns support and it works well. There is the pitfall of having to configure two smoltcp but everything works.

@ivmarkov
Copy link
Collaborator Author

ivmarkov commented Dec 23, 2024

I had a branch for the mdns support and it works well. There is the pitfall of having to configure two smoltcp but everything works.

Alright. Another user in the Embassy matrix chat was trying it out with a pi pico w I think and was having troubles getting the incoming multicast traffic (outgoing was working fine) but I doubt this can be a problem of edge-net if you say it works for you with baremetal esp.

I'll merge in a few days and release.

@lu-zero
Copy link
Contributor

lu-zero commented Dec 23, 2024

I can try to test it more in the next days if you prefer, today I'm far a bit far from the board.

@AnthonyGrondin
Copy link
Contributor

Looking forward to see this being merged, so that I can upgrade to [email protected] across all my packages. [email protected] still depends on [email protected].

I've been testing a bit in the following, using a patched version for this PR:

@lu-zero
Copy link
Contributor

lu-zero commented Dec 25, 2024

If that lands we do not have anymore the pitfall of having two smoltcp in the deptree :)

@lu-zero
Copy link
Contributor

lu-zero commented Dec 26, 2024

I can try to test it more in the next days if you prefer, today I'm far a bit far from the board.

I can confirm that mdns works.

@ivmarkov ivmarkov merged commit 17b6563 into master Jan 2, 2025
1 check passed
@ivmarkov ivmarkov deleted the embassy-net-05 branch August 14, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants