Improve cross-compilation argument - #5
Merged
Merged
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README.md">
<violation number="1" location="README.md:89">
P2: Cross-compilation example omits `BUILD=release`, but default debug build enables ASAN/UBSAN, which can break cross-linking when target sanitizer runtimes are unavailable.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
jserv
requested changes
Mar 21, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Rebase latest 'main' branch to resolve CI breakage.
Previously, the arguments for cross-compilation were not intuitive, requiring users to read the build script to figure them out. This changes it to a simple ARCH argument and updates the document. Change-Id: Ic1f33fa27e41ed00de1f6e837fea6e9feeffff72
Contributor
|
Thank @rota1001 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the arguments for cross-compilation were not intuitive, requiring users to read the build script to figure them out.
For example, the aarch target has to be built with the following commands, which is exhausting:
$ scripts/fetch-lkl.sh aarch64 $ make LKL_DIR=`pwd`/lkl-aarch64 CC=aarch64-linux-gnu-gcc BUILD=release $ make ALPINE_ARCH=aarch64 rootfsThis changes it to a simple
ARCHargument, and the same thing can be done by the following commands:Summary by cubic
Simplified cross-compilation by adding a single
ARCHmake variable that defaults touname -mand flows through build, LKL fetch, and rootfs. Building targets likeaarch64is now a one-liner; host builds are unchanged.ARCHintoLKL_DIR,fetch-lkl.sh(including thefetch-lkltarget), andALPINE_ARCHformkrootfs.sh.README.mdwithARCH/CCexamples and Quick Start notes for host vs target rootfs.Written for commit 535544f. Summary will update on new commits.