Avoid unnecessary spaces created by clang-format #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 6, 2025
|
Squash the comments and then force push. |
Add a statement so that clang-format follows the linux kernel coding style, preventing spaces between a macro's name and the parenthesis. Change-Id: I97bf12cd270c6aef03eca359e29636bb5fb3d616
|
Thank @gg21-aping for contributing! |
yy214123
added a commit
to yy214123/lab0-c
that referenced
this pull request
Mar 6, 2025
Re-run clang-format to apply the changes.
yy214123
added a commit
to yy214123/lab0-c
that referenced
this pull request
Mar 7, 2025
Applied clang-format fixes from PR sysprog21#232. Change-Id: I2f8d1a5a6f0a8242e47a98d27c87550356de0259
[!] queue.c does not follow the consistent coding style.
Make sure you indent as the following:
clang-format -i queue.c
sort: -:449: disorder: onelineMaybe Hook should also be fixed in the same time. Temporarily, I commit without this PR, because I can live with the space syntax, but I can't afford that commit is not allowed. |
Create a new issue along with comprehensive descriptions. |
yy214123
added a commit
to yy214123/lab0-c
that referenced
this pull request
Mar 19, 2025
Applied clang-format fixes from PR sysprog21#232. Change-Id: I2f8d1a5a6f0a8242e47a98d27c87550356de0259
yy214123
added a commit
to yy214123/lab0-c
that referenced
this pull request
Mar 20, 2025
Applied clang-format fixes from PR sysprog21#232. Change-Id: I2f8d1a5a6f0a8242e47a98d27c87550356de0259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
.clang_formatcreates a space between a macro's name and the parenthesis, which does not follow the kernel coding style. The change is made so the unnecessary parenthesis will not be created.Change-Id: I97bf12cd270c6aef03eca359e29636bb5fb3d616