Fix incorrect do_size argument usage
#238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 6, 2025
Previously, the error message in 'do_size' referenced 'argv[2]' instead of 'argv[1]'. Since 'argc' is at most 2 in this context, 'argv[2]' is always null, as defined in Section 5.1.2.2.1 of the C11 standard. While GCC prints "(null)" for a null pointer in '%s' formatting, this behavior is implementation-defined. Other compilers may cause undefined behavior, potentially leading to a segmentation fault. This change ensures the correct argument is used, avoiding reliance on implementation-specific behavior and preventing potential crashes. Change-Id: I27748efd7c3d533659a6eda78f7c68ced2e78366
|
Thank @Dennis40816 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects a bug in the
do_sizefunction and reformatsqtest.cto comply with the updated clang-format configuration introduced in commit c9f7b87. The formatting update is required because clang-format will reject commits that do not conform to the enforced style.In
do_size, the error message incorrectly referencedargv[2], which is alwaysNULLwhenargcis 2:Additionally, according to the C11 standard, passing a
NULLpointer to '%s' results in undefined behavior:This update changes the argument to
argv[1], ensuring the accuracy of the error message's meaning and that a valid pointer is always used.