Ensure repetitions input is at least 1 #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing 0 or a negative value for repetitions does not cause errors, as the input is an integer. However, this behavior may be confusing for users. To improve clarity, enforce repetitions to be an integer greater than or equal to 1 and return an error if the input is invalid. Change-Id: Ifbe1e1846f6eac2c933a00a3a9af5d4c533f3c5f
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing 0 or a negative value for repetitions does not cause errors, as the input is an integer. However, this behavior may be confusing for users. To improve clarity, enforce repetitions to be an integer greater than or equal to 1 and return an error if the input is invalid.
Change-Id: Ifbe1e1846f6eac2c933a00a3a9af5d4c533f3c5f