Fix console hang after exceeding input limit #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 9, 2025
console.c
Outdated
| report( | ||
| 1, | ||
| "Error limit exceeded. Stopping command execution, and quitting"); | ||
| do_quit(0, NULL); |
There was a problem hiding this comment.
Don't do this. The functions starting with do_ are only used by the command interpreter during command dispatching. You can introduce another helper function for both do_quit and record_error.
There was a problem hiding this comment.
I have introduced a helper function, force_quit, in the latest commit to handle both do_quit and record_error. This ensures that functions starting with do_ remain strictly for command dispatching while reducing code duplication and improving maintainability.
EricccTaiwan
force-pushed
the
fix-record_error
branch
from
57a52a4 to
ed59d25
Compare
- Fixed issue where exceeding the error limit (five attempts) did not exit the console, potentially leading to memory leaks. - Introduced "force_quit" as a helper function to centralize quit handling. - Ensured both "do_quit" and "record_error" call "force_quit", enforcing a consistent function structure. - Reduced code duplication and improved command dispatching logic. Co-authored-by: charliechiou <[email protected]> Change-Id: I2f624a16cc4eb3517bf05a65eac105908300bfd9
EricccTaiwan
force-pushed
the
fix-record_error
branch
from
41a2948 to
9991969
Compare
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the console input exceeds the error limit (five attempts), it displays: "Error limit exceeded. Stopping command execution." However, it does not exit the command prompt. Additionally, attempting to quit using the "quit" command fails, leaving Ctrl+C as the only way to terminate the program, which may lead to memory leaks.
This commit fixes the issue by declaring do_quit before record_error and calling it upon reaching the error limit to prevent memory leaks.
Alternative solutions considered:
This approach balances maintainability and immediate resolution, ensuring the console exits properly once the input limit is exceeded.
Change-Id: I52d53f69156bff2ab793afba65b46c67c125671f