Skip to content

Conversation

EricccTaiwan
Copy link
Contributor

@EricccTaiwan EricccTaiwan commented Mar 10, 2025

Enhance the log command by providing clearer feedback to users. Now, if no log file is specified, the message explicitly suggests using log <file> for better clarity. Additionally, a message is printed when logging is enabled, improving user awareness.

Before: Ambiguous log command feedback

$ ./qtest
cmd> log
No log file given
cmd> log temp.txt
cmd> new
l = []
cmd> quit
Freeing queue
$

After: Clear and informative log command messages

$ ./qtest
cmd> log
No log file given. Use 'log <file>'. 
cmd> log temp.txt
Logging enabled: temp.txt 
cmd> new
l = []
cmd> quit
Freeing queue
$
$ cat temp.txt
l = []
Freeing queue
$

Change-Id: I355f3f13bd959ddecc2893d202642accc565fb8a

Enhance the "log" command by providing clearer feedback to users.
Now, if no log file is specified, the message explicitly suggests
using "log <file>" for better clarity. Additionally, a message is
printed when logging is enabled, improving user awareness.

Co-authored-by: charliechiou <[email protected]>
Change-Id: I359cb621cf584f149c96226bb183403174880cd9
@jserv jserv merged commit 9711c67 into sysprog21:master Mar 11, 2025
1 of 2 checks passed
@jserv
Copy link
Contributor

jserv commented Mar 11, 2025

Thank @EricccTaiwan for contributing!

@EricccTaiwan EricccTaiwan deleted the fix-do_log branch March 11, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants