Extract Textfield helpers #9
Merged
+244
−158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test suite in tests/test-input.c verifies: - Selection shrinking behavior (cursor jumps to boundary before move) - Word skipping with Ctrl+Shift - UTF-8 boundary handling - Selection extension with Shift held
This breaks down the large iui_process_text_input_selection function in src/input.c into modular static helper functions to improve readability and maintainability. The following helpers were introduced: - textfield_clamp_state: Validate cursor/selection boundaries - textfield_insert_char: Handle UTF-8 insertion logic - textfield_move_left/right: Word skipping and cursor movement - textfield_handle_cursor_movement: Unified key event dispatch
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Refactored textfield input handling into small helper functions to improve readability and keep UTF-8 correctness. Added tests for selection boundary behavior and arrow/word navigation.
Refactors
Bug Fixes
Written for commit bfc4440. Summary will update on new commits.