Skip to content

Fix incorrect gpio_free_array usage and improve softirqs formatting #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

Fix incorrect gpio_free_array usage and improve softirqs formatting #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cca6b4d
Improve formatting for softirqs explanation
Jordymalone Aug 27, 2025
2c88f74
Fix incorrect array size in gpio_free_array call
Jordymalone Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/bh_threaded.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ static int __init bottomhalf_init(void)
free_irq(button_irqs[0], &buttons[0]);

fail2:
gpio_free_array(buttons, ARRAY_SIZE(leds));
gpio_free_array(buttons, ARRAY_SIZE(buttons));

fail1:
gpio_free_array(leds, ARRAY_SIZE(leds));
Expand Down
2 changes: 1 addition & 1 deletion examples/bottomhalf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ static int __init bottomhalf_init(void)
free_irq(button_irqs[0], NULL);

fail2:
gpio_free_array(buttons, ARRAY_SIZE(leds));
gpio_free_array(buttons, ARRAY_SIZE(buttons));

fail1:
gpio_free_array(leds, ARRAY_SIZE(leds));
Expand Down
2 changes: 1 addition & 1 deletion examples/intrpt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ static int __init intrpt_init(void)
free_irq(button_irqs[0], NULL);

fail2:
gpio_free_array(buttons, ARRAY_SIZE(leds));
gpio_free_array(buttons, ARRAY_SIZE(buttons));

fail1:
gpio_free_array(leds, ARRAY_SIZE(leds));
Expand Down
2 changes: 1 addition & 1 deletion lkmpg.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1778,7 +1778,7 @@ \subsection{Spinlocks}
In contrast, \cpp|spin_lock_irqsave()| disables interrupts and also saves the interrupt state, ensuring that interrupts are restored to their previous state when the lock is released.
This makes \cpp|spin_lock_irqsave()| a safer option in scenarios where preserving the interrupt state is crucial.

Next, \cpp|spin_lock_bh()| disables softirqs (software interrupts) but allows hardware interrupts to continue.
Next, \cpp|spin_lock_bh()| disables \textbf{softirqs} (software interrupts) but allows hardware interrupts to continue.
Unlike \cpp|spin_lock_irq()| and \cpp|spin_lock_irqsave()|, which disable both hardware and software interrupts, \cpp|spin_lock_bh()| is useful when hardware interrupts need to remain active.

For more information about spinlock usage and lock types, see the following resources:
Expand Down