ioctl: Clean up error handling and return codes #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricccTaiwan
suggested changes
Sep 3, 2025
examples/ioctl.c
Outdated
Comment on lines
166
to
167
| if (ret) | ||
| goto error; |
There was a problem hiding this comment.
Instead of goto, just handle it directly, wdyt?
if (ret) {
unregister_chrdev_region(dev, num_of_dev);
return ret;
}Simplify the init routine by: - Removing unnecessary temporary variables - Adding spacing between declarations and statements - Using early return on alloc_chrdev_region() failure - Propagating the actual error code instead of always returning -1 - Dropping redundant checks in the error path This makes the error handling clearer and more consistent with common kernel coding style.
visitorckw
force-pushed
the
cleanup-ioctl
branch
from
9c8810c to
5087227
Compare
EricccTaiwan
approved these changes
Sep 3, 2025
|
Thank @visitorckw for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the init routine by:
This makes the error handling clearer and more consistent with common kernel coding style.