Skip to content

ioctl: Clean up error handling and return codes #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

ioctl: Clean up error handling and return codes #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions examples/ioctl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,29 +152,25 @@ static struct file_operations fops = {
static int __init ioctl_init(void)
{
dev_t dev;
int alloc_ret = -1;
int cdev_ret = -1;
alloc_ret = alloc_chrdev_region(&dev, 0, num_of_dev, DRIVER_NAME);
int ret;

if (alloc_ret)
goto error;
ret = alloc_chrdev_region(&dev, 0, num_of_dev, DRIVER_NAME);

if (ret)
return ret;

test_ioctl_major = MAJOR(dev);
cdev_init(&test_ioctl_cdev, &fops);
cdev_ret = cdev_add(&test_ioctl_cdev, dev, num_of_dev);
ret = cdev_add(&test_ioctl_cdev, dev, num_of_dev);

if (cdev_ret)
goto error;
if (ret) {
unregister_chrdev_region(dev, num_of_dev);
return ret;
}

pr_alert("%s driver(major: %d) installed.\n", DRIVER_NAME,
test_ioctl_major);
return 0;
error:
if (cdev_ret == 0)
cdev_del(&test_ioctl_cdev);
if (alloc_ret == 0)
unregister_chrdev_region(dev, num_of_dev);
return -1;
}

static void __exit ioctl_exit(void)
Expand Down