Skip to content

Conversation

Jordymalone
Copy link
Contributor

Remove extra spaces before \item under \begin{itemize} to normalize indentation. This change is formatting-only and does not alter any text content. Normalized style reduces unnecessary diff noise and improves consistency across the document.

Copy link
Collaborator

@EricccTaiwan EricccTaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jserv
Copy link
Contributor

jserv commented Sep 4, 2025

The indention should be restored.

@Jordymalone
Copy link
Contributor Author

The indention should be restored.

Understood. But I noticed the file mixes different indentation styles for \item.
Should I fully restore everything as before?
Or keep \begin{itemize}/\end{itemize} left-aligned and normalize all \item to a consistent indent (e.g., two spaces)?

@EricccTaiwan
Copy link
Collaborator

EricccTaiwan commented Sep 4, 2025

The indention should be restored.

I think it would be nice to keep the formatting consistent.

@jserv
Copy link
Contributor

jserv commented Sep 4, 2025

Or keep \begin{itemize}/\end{itemize} left-aligned and normalize all \item to a consistent indent (e.g., two spaces)?

The preferable style would be:

\begin{enumerate}
  \item The application loads the syscall number into a CPU register (e.g., \verb|EAX| on x86)                                                         
  \item A special instruction triggers the transition (\verb|int 0x80| or \verb|sysenter| on x86)
  \item The CPU switches to kernel mode and jumps to the syscall handler
  \item The kernel validates arguments, performs the operation, and returns the result
  \item Control returns to user mode with the result in a register
\end{enumerate}

Use two space indention.

Apply a consistent two space indentation for all \item entries under
list environments, while keeping \begin{itemize}/\end{itemize}
left-aligned. This is a formatting-only update with no content changes,
improving consistency across the document.

Co-authored-by: EricccTaiwan <[email protected]>
Signed-off-by: Chia-Hao Chiu <[email protected]>
@jserv jserv merged commit 821caa5 into sysprog21:master Sep 5, 2025
1 check passed
@jserv
Copy link
Contributor

jserv commented Sep 5, 2025

Thank @Jordymalone for contributing!

@Jordymalone Jordymalone deleted the fix-indent branch September 5, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants