Prevent crashes from invalid closures in work/timeout queues #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform-aware pointer validation is added to prevent invalid memory access when callbacks execute with freed widget pointers. It validates closures both at scheduling time and before execution. Fixes crashes in _twin_toplevel_paint() during mouse event handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform-aware pointer validation is added to prevent invalid memory access when callbacks execute with freed widget pointers. It validates closures both at scheduling time and before execution.
Fixes crashes in _twin_toplevel_paint() during mouse event handling.
Summary by Bito
This pull request implements critical bug fixes to prevent crashes from invalid closure pointers in work and timeout queues. It introduces platform-aware pointer validation, ensuring closures are validated at both scheduling and execution times, addressing memory access violations during mouse event handling.