Skip to content

Conversation

@eastWillow
Copy link
Contributor

@eastWillow eastWillow commented Sep 18, 2025

When building neatvnc v0.8.1, the following error occurs:

meson.build:71:7: ERROR: Dependency "aml" not found, tried pkgconfig and cmake

According to meson.build:66, neatvnc explicitly requires:

aml_version = ['>=0.3.0', '<0.4.0']

This PR updates the dependency to match the required aml version range (0.3.x).
It ensures the build succeeds and prevents version mismatch issues.

Checklist:

  • Verified that build succeeds with aml v0.3.0
  • Confirmed run demo program with the VNC backend

Summary by cubic

Pins aml to v0.3.0 in build-neatvnc.sh to match neatvnc v0.8.1’s >=0.3.0,<0.4.0 requirement and fix the Meson “Dependency aml not found” error. Also makes cloning idempotent for aml and neatvnc.

@jserv jserv requested a review from ndsl7109256 September 18, 2025 13:05
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 1 file

Prompt for AI agents (all 4 issues)

Understand the root cause of the following 4 issues and fix them.


<file name="tools/build-neatvnc.sh">

<violation number="1" location="tools/build-neatvnc.sh:9">
Existing aml directory is not validated or checked out to v0.3.0; build may use the wrong version.</violation>

<violation number="2" location="tools/build-neatvnc.sh:12">
pushd aml lacks error handling; if clone fails or dir is missing, subsequent commands may run in the wrong directory.</violation>

<violation number="3" location="tools/build-neatvnc.sh:20">
Existing neatvnc directory is not validated or checked out to v0.8.1; build may use the wrong version.</violation>

<violation number="4" location="tools/build-neatvnc.sh:23">
pushd neatvnc lacks error handling; on failure the script may proceed in the wrong directory.</violation>
</file>


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Ask questions if you need clarification on any suggestion

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@eastWillow eastWillow force-pushed the main branch 2 times, most recently from 38cd04e to 965f823 Compare October 13, 2025 15:07
@jserv
Copy link
Contributor

jserv commented Oct 13, 2025

Rather than remaining on neatvnc v0.8.1, would you consider supporting its newer releases?

@eastWillow
Copy link
Contributor Author

Rather than remaining on neatvnc v0.8.1, would you consider supporting its newer releases?

OK, I’ve updated neatvnc to v0.9.5

Build succeeds and runs fine.

image

@jserv jserv changed the title Fix aml dependency version for neatvnc Bump neatvnc package dependency Oct 14, 2025
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refine git commit messages according to https://cbea.ms/git-commit

Bump neatvnc from v0.8.1 to v0.9.5 and ensure compatibility with the
proper aml version.

According to meson.build:66, neatvnc requires aml in the range
`>=0.3.0` and `<0.4.0`.
@eastWillow eastWillow requested a review from jserv October 15, 2025 14:36
@jserv jserv merged commit 4f4ee7c into sysprog21:main Oct 15, 2025
3 checks passed
@jserv
Copy link
Contributor

jserv commented Oct 15, 2025

Thank @eastWillow for contributing!

@eastWillow
Copy link
Contributor Author

Thanks for the merge.
I’ll keep an eye on related issues and help improve further if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants