-
Notifications
You must be signed in to change notification settings - Fork 23
Bump neatvnc package dependency #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 issues found across 1 file
Prompt for AI agents (all 4 issues)
Understand the root cause of the following 4 issues and fix them.
<file name="tools/build-neatvnc.sh">
<violation number="1" location="tools/build-neatvnc.sh:9">
Existing aml directory is not validated or checked out to v0.3.0; build may use the wrong version.</violation>
<violation number="2" location="tools/build-neatvnc.sh:12">
pushd aml lacks error handling; if clone fails or dir is missing, subsequent commands may run in the wrong directory.</violation>
<violation number="3" location="tools/build-neatvnc.sh:20">
Existing neatvnc directory is not validated or checked out to v0.8.1; build may use the wrong version.</violation>
<violation number="4" location="tools/build-neatvnc.sh:23">
pushd neatvnc lacks error handling; on failure the script may proceed in the wrong directory.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
38cd04e to
965f823
Compare
|
Rather than remaining on neatvnc v0.8.1, would you consider supporting its newer releases? |
jserv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine git commit messages according to https://cbea.ms/git-commit
Bump neatvnc from v0.8.1 to v0.9.5 and ensure compatibility with the proper aml version. According to meson.build:66, neatvnc requires aml in the range `>=0.3.0` and `<0.4.0`.
OK. |
|
Thank @eastWillow for contributing! |
|
Thanks for the merge. |

When building neatvnc v0.8.1, the following error occurs:
According to
meson.build:66, neatvnc explicitly requires:This PR updates the dependency to match the required aml version range (
0.3.x).It ensures the build succeeds and prevents version mismatch issues.
Checklist:
Summary by cubic
Pins aml to v0.3.0 in build-neatvnc.sh to match neatvnc v0.8.1’s >=0.3.0,<0.4.0 requirement and fix the Meson “Dependency aml not found” error. Also makes cloning idempotent for aml and neatvnc.