Skip to content

Conversation

@eastWillow
Copy link
Contributor

@eastWillow eastWillow commented Oct 13, 2025

This patch fixes the menuconfig style issue on Windows:

  1. "back" is not a valid color name in _NAMED_COLORS.
  2. The Windows Python environment does not support -1 as a color value.

To improve cross-platform compatibility, the background color has been explicitly set to black.

Before:
image

After:
image


Summary by cubic

Fix Windows menuconfig styling by replacing the invalid background color “back” with “black” in the path style. This avoids Windows terminal color errors (-1 not supported) and ensures consistent, readable colors.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@jserv
Copy link
Contributor

jserv commented Oct 13, 2025

This patch fixes the menuconfig style issue on Windows:

  1. "back" is not a valid color name in _NAMED_COLORS.
  2. The Windows Python environment does not support -1 as a color value.
    To improve cross-platform compatibility, the background color has been explicitly set to black.

Please focus on improving sysprog21/Kconfiglib, as the Mado project is about to migrate from its old copy of Kconfiglib to the refined version.

1. back is not the color name in _NAMED_COLORS
2. windows terminal python enviroment not support the -1 as the color
@eastWillow eastWillow force-pushed the fix-windows-menuconfig-style branch from 3a11ed0 to 428b26b Compare October 14, 2025 15:03
@eastWillow
Copy link
Contributor Author

This patch fixes the menuconfig style issue on Windows:

  1. "back" is not a valid color name in _NAMED_COLORS.
  2. The Windows Python environment does not support -1 as a color value.
    To improve cross-platform compatibility, the background color has been explicitly set to black.

Please focus on improving sysprog21/Kconfiglib, as the Mado project is about to migrate from its old copy of Kconfiglib to the refined version.

  1. Make config target use refined Kconfiglib if available
  2. Maintains fallback to local tools for environments without Kconfiglib.

@jserv
Copy link
Contributor

jserv commented Oct 14, 2025

  1. Make config target use refined Kconfiglib if available
  2. Maintains fallback to local tools for environments without Kconfiglib.

Don't do that. The directory tools/kconfig will be completely replaced with sysprog21/Kconfiglib. You should validate the Windows compatibility for that.

@eastWillow
Copy link
Contributor Author

I’ve validated that sysprog21/Kconfiglib works correctly on Windows.
It runs fine in my environment.

python3.13 -m menuconfig configs/Kconfig

image

Is there anything I can do to help prevent issues for other Windows users like me?
Or should I just close this pull request?

@jserv
Copy link
Contributor

jserv commented Oct 16, 2025

Deprecated by #126

@jserv jserv closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants