Bring wasm service up #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChinYikMing
force-pushed
the
fix-wasm-service
branch
from
70ae4c5 to
74af7cc
Compare
|
I changed to title in #486. The ELF selection list generator is in progress and may take some time. To bring up the WASM service quickly, this PR could be merged first. |
ChinYikMing
force-pushed
the
fix-wasm-service
branch
from
976909a to
bc68875
Compare
jserv
reviewed
Sep 2, 2024
jserv
requested changes
Sep 2, 2024
After merging sysprog21#474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target. Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered. Related: sysprog21#486
As the number of ELF executables may increase over time, manually updating the HTML ELF list becomes tedious. Therefore, an ELF list generator has been introduced. When new ELF executables are added to the build or build/riscv32 directories, the list will be generated dynamically. Close: sysprog21#486
ChinYikMing
force-pushed
the
fix-wasm-service
branch
from
bc68875 to
785bf15
Compare
|
Thank @ChinYikMing for contributing! |
ChinYikMing
added a commit
to ChinYikMing/rv32emu
that referenced
this pull request
Sep 2, 2024
After merging sysprog21#487, the elf_list.js file is generated dynamically, and the wasm service requires this file to run. However, during CI deployment, the file is not pushed to the rv32emu-demo repo, causing the GitHub Pages to malfunction. To resolve this, pushing the file to the rv32emu-demo repo is the solution. The 'demo' directory is only created when the WASM service runs locally. To address this, the elf_list.js file should be placed in the 'build' directory instead, as the CI deployment does not invoke the Makefile's start-web target, so the 'demo' directory will not be generated.
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Bring WebAssembly service up
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
After merging sysprog21#487, the elf_list.js file is generated dynamically, and the wasm service requires this file to run. However, during CI deployment, the file is not pushed to the rv32emu-demo repo, causing the GitHub Pages to malfunction. To resolve this, pushing the file to the rv32emu-demo repo is the solution. The 'demo' directory is only created when the WASM service runs locally. To address this, the elf_list.js file should be placed in the 'build' directory instead, as the CI deployment does not invoke the Makefile's start-web target, so the 'demo' directory will not be generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target.
Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered.
As the number of ELF executables may increase over time, manually updating the HTML ELF list becomes tedious. Therefore, an ELF list generator has been introduced. When new ELF executables are added to the build or build/riscv32 directories, the list will be generated dynamically.
Close: #486