Skip to content

Conversation

ChinYikMing
Copy link
Collaborator

Normal 'make' or 'make all' does not require downloading prebuilt ELF executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always depends on the 'artifact' target, even when not using emcc, causing 'make' or 'make all' to always download prebuilt ELF executables. To prevent this, the 'artifact' target is moved under the emcc build condition.

Related: #491

Normal 'make' or 'make all' does not require downloading prebuilt ELF
executables from the rv32emu-prebuilt repo. However, 'deps_emcc' always
depends on the 'artifact' target, even when not using emcc, causing 'make'
or 'make all' to always download prebuilt ELF executables. To prevent this,
the 'artifact' target is moved under the emcc build condition.

Related: sysprog21#491
@jserv jserv requested a review from vacantron September 6, 2024 15:00
@jserv jserv added this to the release-2024.1 milestone Sep 6, 2024
@jserv jserv merged commit abb1135 into sysprog21:master Sep 6, 2024
8 checks passed
@ChinYikMing ChinYikMing deleted the avoid-repeat-download branch September 6, 2024 15:10
vestata pushed a commit to vestata/rv32emu that referenced this pull request Jan 24, 2025
Move artifact target under emcc build condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants