Skip to content

Conversation

vacantron
Copy link
Collaborator

@vacantron vacantron commented Feb 13, 2025

The RISCOF crashes intermittently and at different locations, and also takes a long time to reproduce. So, drop the test in Arm64 CI and run tests only locally.

Related PRs:

Summary by Bito

Implementation of structured dependency management through requirements.txt, including RISCOF and its dependencies. Updated CI scripts to use requirements file instead of git installation. Refined toolchain installation process with improved command syntax. Changes target RISCOF test stability improvements on Arm64 platforms.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Copy link

bito-code-review bot commented Feb 13, 2025

Code Review Agent Run #8739d0

Actionable Suggestions - 1
  • requirements.txt - 1
    • Consider upgrading PyYAML for security · Line 20-20
Review Details
  • Files reviewed - 4 · Commit Range: 4397618..2052a1f
    • .ci/riscv-tests.sh
    • .ci/riscv-toolchain-install.sh
    • mk/riscv-arch-test.mk
    • requirements.txt
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

Copy link

bito-code-review bot commented Feb 13, 2025

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Feature Improvement - Dependency Management Enhancement

requirements.txt - Added new file with comprehensive Python package dependencies

riscv-tests.sh - Updated RISCOF installation to use requirements.txt

riscv-arch-test.mk - Modified dependency check message to reference requirements.txt

riscv-toolchain-install.sh - Improved toolchain extraction command syntax

@visitorckw
Copy link
Collaborator

In the commit message, the phrase "Replacing 'apt-get' with 'apt-get'" looks like a typo to me.

Replacing "apt-get" with "apt" in Arm64 CI is less likely to cause
the process crash.

Install Python packages via requirements.txt to minimize errors.
The RISCOF crashes intermittently and at different locations, and also
takes a long time to reproduce. So, drop the test in Arm64 CI and run
tests only locally.
@jserv jserv merged commit 61e4d11 into sysprog21:master Feb 13, 2025
8 checks passed
@jserv
Copy link
Contributor

jserv commented Feb 13, 2025

Thank @vacantron for contributing!

Copy link

bito-code-review bot commented Feb 13, 2025

Code Review Agent Run #ce6b10

Actionable Suggestions - 0
Additional Suggestions - 1
  • .ci/riscv-toolchain-install.sh - 1
    • Consider wget quiet mode and tar args · Line 27-27
Review Details
  • Files reviewed - 4 · Commit Range: cda91e8..9e775ba
    • .ci/riscv-tests.sh
    • .ci/riscv-toolchain-install.sh
    • mk/riscv-arch-test.mk
    • requirements.txt
  • Files skipped - 1
    • .github/workflows/main.yml - Reason: Filter setting
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@jserv jserv added this to the release-2025.1 milestone Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants