Allow emcc build and validate in CI #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emcc generates Wasm but not a native executable, making the generated bin2c non-executable. As a result, the device tree blob cannot be built into a C application. To resolve this, fall back to a native compiler gcc or clang to build bin2c. Additionally, ensuring CC is set to gcc, clang, or emcc. Otherwise, trigger a build error early. Related: sysprog21#534
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes?
Allow emcc build for both ISA or system emulation. Additionally, add emcc build check to CI.
How to reproduce emcc build fail for system emulation?
Will see the error like the following:
The reason is that the
bin2cis compiled to Wasm byemccinstead of native executable which cannot build the device tree blob to C application.Summary by Bito
This pull request enhances the build system by introducing support for emcc, enabling ISA and system emulation. It includes checks for GCC or Clang usage when emcc is unsuitable and implements error handling for unsupported compilers, improving robustness.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2