Skip to content

Conversation

Lzzz666
Copy link
Contributor

@Lzzz666 Lzzz666 commented May 16, 2025

log_level is dynamic (attr->log_level)

Summary by Bito

This pull request clarifies the logging functionality in the RISC-V implementation by removing a misleading comment. It updates the documentation to accurately reflect the dynamic nature of the log level based on the provided attribute, enhancing code clarity.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 2

log_level is dynamic (attr->log_level)
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Benchmark suite Current: 2ab686a Previous: a27625b Ratio
Dhrystone 1322 Average DMIPS over 10 runs 1285 Average DMIPS over 10 runs 0.97
Coremark 922.46 Average iterations/sec over 10 runs 915.126 Average iterations/sec over 10 runs 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Collaborator

@ChinYikMing ChinYikMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jserv
Copy link
Contributor

jserv commented May 18, 2025

@vacantron, can you confirm the CI breakage of macOS-Arm64?

@jserv jserv merged commit e418b67 into sysprog21:master May 22, 2025
41 of 46 checks passed
@jserv
Copy link
Contributor

jserv commented May 22, 2025

Thank @Lzzz666 for contributing!

@jserv jserv added this to the release-2025.2 milestone May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants