Fix incorrect clock calculation on macOS #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change |
|
Issue found in #59. |
chiangkd
changed the title
Also the title in the commit, you may force push after changing. |
jserv
requested changes
Sep 11, 2024
The current implementation of 'semu_timer_clocksource()' returns the clock source in nanoseconds, but it should return in seconds for correct system integration. Adjust the function on macOS to divide the return value by 1e9, ensuring the clock source is provided in seconds.
|
Thank @chiangkd for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
semu_timer_clocksource()returns the clock source in nanoseconds when building on macOS. Causing an abnormal timestamp in the boot log.Divide the return value by 1e9, ensuring the clock source is provided in seconds.