-
Notifications
You must be signed in to change notification settings - Fork 61
Reorganize project structure #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I remember someone mentioned that the current handwritten Makefile might not be able to handle multiple build configurations and rules well before, which could lead to confusion for users. As a result, there was a suggestion to switch to build systems like CMake or Meson. Maybe we could take this opportunity to discuss it as well? |
Hi @Mes0903 , Let me illustrate my thoughts.
For Meson, I have no any opinions as I haven't write any build configuration using Meson. As you have mention these build tools, I just come up with using |
Hi @Cuda-Chen , I agree with your point. The reason I mentioned Meson and CMake is just because I heard someone else suggest them before. Maybe ninja would be a good option. |
- "3rdparty/": location for submodules - "include/": location for headers - "build/": location for intermediate files and binaries - "src/": location for source codes
IMO, If we are struggling in the configuration, I think that we need an assistant system like |
LGTM, although the original issue seems to have been resolved by minigdb, I think being able to reorganize project structure is quite nice. For this PR, I can compile and run it successfully in my Ubuntu environment now, but there’s one problem: it currently have mini-gdbstub pinned at 39020f2… while keeping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase the latest 'master' branch.
Known issue
The submodulemini-gdbstub
would install a git hook by default and report an error because it is not at the project's root. I have open an issue for this.