Codebase cleanup #180
Merged
Codebase cleanup #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to current shecc's implementation, modern editors with common lsp such as VSCode with C/C++ plugin is unable to properly analyze from main.c, even though the code is correct. Thus we adds some system header inclusion in certain files to resolve and suppress error message. Notice that due to current frontend's limitation, including defs.h in C source files other than main.c would result weird error, thus this is not introduced in this commit. In addition, it's annoying that VSCode always generate .vscode folder with some plugin-specific setting config files. Therefore, we also ignore it to prevent accidentally adding the config file to stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to current shecc's implementation, modern editors with common lsp such as VSCode with C/C++ plugin is unable to properly analyze from main.c, even though the code is correct. Thus we adds some system header inclusion in certain files to resolve and suppress error message. Notice that due to current frontend's limitation, including defs.h in C source files other than main.c would result weird error, thus this is not introduced in this commit.
In addition, it's annoying that VSCode always generate .vscode folder with some plugin-specific setting config files. Therefore, we also ignore it to prevent accidentally adding the config file to stage.