Correct the return value of fputc function #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 7, 2025
DrXiao
force-pushed
the
libc/fix-fputc
branch
4 times, most recently
from
47bc037 to
924d629
Compare
jserv
reviewed
Apr 8, 2025
jserv
reviewed
Apr 8, 2025
jserv
requested changes
Apr 8, 2025
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Rebase the latest master branch and resolve the conflicts.
According to the man page, the return value of fputc() should be either the character written as an "unsigned char" cast to an "int" or EOF on error, but the current implementation doesn't follow the specification. Therefore, these changes correct the implementation to return the ASCII code of the written character or -1 if the output fails, thereby matching the description in the man page. Additionally, the necessary test cases are also added to validate the correctness.
Collaborator
|
Thank @DrXiao for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the man page, the return value of
fputc()should be either the character written as anunsigned charcast to anintorEOFon error, but the current implementation doesn't follow the specification.Therefore, the proposed changes correct the implementation to return the ASCII code of the written character or -1 if the output fails, thereby matching the description in the man page.
Additionally, the necessary test cases are also added to validate the correctness.
Summary by Bito
This pull request corrects the fputc function implementation to return the ASCII code of the written character or -1 on error, as per specifications. It also adds comprehensive test cases to validate the function's behavior, improving reliability and testing coverage.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2