Allow parameter list to be a single "void" #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChAoSUnItY
suggested changes
May 18, 2025
Collaborator
ChAoSUnItY
left a comment
ChAoSUnItY
left a comment
There was a problem hiding this comment.
Please add tests in tests/driver.sh to validate your work follows specification's description.
Collaborator
|
The current shecc also contains functions such as |
ChAoSUnItY
suggested changes
May 20, 2025
Collaborator
ChAoSUnItY
left a comment
ChAoSUnItY
left a comment
There was a problem hiding this comment.
Rebase the latest master branch and resolve the error.
lumynou5
force-pushed
the
void-parameter-list
branch
from
d025779 to
2649b08
Compare
A parameter list is either a single keyword "void" or a comma-separated list of parameters according to the standard. Previously, only the latter is supported, and the former leads to unexpected token errors.
'void' must be the only parameter and unnamed to indicate no parameters. Previously, the check for functions with first parameter of void pointer, etc. didn't consider the illegal forms, so those could pass compilation.
Adds the keyword "void" to the parameter lists of functions. This helps validation of the implementation of "void" parameter lists in the bootstrapping process. Especially K&R style exists until C23, though it's not implemented in shecc now, shecc is first built by another compiler such as gcc and is written in C99 (as per Makefile). Suggested-by: Yu-En Hsiao <[email protected]>
lumynou5
force-pushed
the
void-parameter-list
branch
from
2649b08 to
fb762cd
Compare
Collaborator
|
Thank @lumynou5 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A parameter list is either a single keyword "void" or a comma-separated list of parameters according to the standard. Previously, only the latter is supported, and the former leads to unexpected token errors.
Summary by Bito
This pull request significantly enhances the parser by allowing a single 'void' keyword as a valid parameter list, resolving unexpected token errors and standardizing function signatures across multiple files. New tests have been added to ensure robust handling of parameter declarations.Unit tests added: True
Estimated effort to review (1-5, lower is better): 2 - The changes are clear and well-documented, making the review process straightforward.