Fix parsing to support uppercase 0X hex literals #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Jul 13, 2025
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Run clang-format -i prior to submit.
Previously, literals with uppercase 0X prefix (e.g., "0XABC") were misparsed as invalid. This commit fixes that and improves compatibility with C99-style numeric constants. - Removed incorrect inclusion of 'x' as a hex digit in is_hex() - Updated is_numeric() to skip 0x/0X prefix when validating hex digits - Adjusted read_numeric_constant() to consistently handle both 0x and 0X prefixes
fourcolor
force-pushed
the
fix/hex-0X-support
branch
from
b6c708a to
49bcd8b
Compare
jserv
requested changes
Jul 13, 2025
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Consolidate the test suite to reflect the proposed changes.
DrXiao
reviewed
Jul 14, 2025
|
|
||
| bool is_hex(char c) | ||
| { | ||
| return ((c >= '0' && c <= '9') || (c >= 'a' && c <= 'f') || c == 'x' || |
Collaborator
There was a problem hiding this comment.
How about adding c == 'X' to the expression instead of removing c == 'x' ?
If so, the proposed changes could be refined accordingly.
Contributor
Author
There was a problem hiding this comment.
I think we should avoid treating 'x' or 'X' as valid hex digits, since they are part of the prefix (0x or 0X) but not valid hex characters themselves.
Add tests to verify valid and invalid forms of hex literals.
DrXiao
approved these changes
Jul 14, 2025
Collaborator
|
Thank @fourcolor for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, literals with uppercase 0X prefix (e.g., "0XABC") were misparsed as invalid. This commit fixes that and improves compatibility with C99-style numeric constants.
Summary by Bito
This pull request enhances numeric literal parsing by adding support for uppercase 0X hexadecimal prefixes, correcting previous misparsing issues. Modifications were made to the is_hex and is_numeric functions for better validation, and the read_numeric_constant function was updated for consistent handling of both prefix styles, improving C99 compatibility. New tests have been included to ensure the accuracy of these changes.