Fix potential segfault when reporting error #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reaching to SSA phase, the "error" function would always cause segment fault due to the internal design, which is the source index is always going to be out of bound. In this patch, we instead use "fatal" function to avoid this issue.
Collaborator
Create a dedicated issue to raise the above. |
Collaborator
|
Thank @ChAoSUnItY for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reaching to SSA phase, the
errorfunction would always cause segment fault due to the internal design, which is the source index is always going to be out of bound. In this patch, we instead usefatalfunction to avoid this issue.Summary by Bito
This pull request fixes a critical bug in the SSA phase by replacing the 'error' function with 'fatal', preventing segmentation faults from out-of-bounds indices. This change significantly enhances the stability of the code during execution.