Fix inliner string escaping #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds proper backslash escaping in inliner.c to prevent unmatched
quotes when processing strings with escaped characters and integrates
norm-lf preprocessing into the build pipeline.
The key fix is in write_line() which now properly escapes backslashes
before quotes, preventing corruption like:
Input: printf("Hello \"world\"\n");
Before: __c("printf(\"Hello \"world\"\n\");"); // Corrupted!
After: __c("printf(\"Hello \\\"world\\\"\\n\");"); // Correct!
Close #141
ChAoSUnItY
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper backslash escaping in inliner.c to prevent unmatched quotes when processing strings with escaped characters and integrates norm-lf preprocessing into the build pipeline.
The key fix is in write_line() which now properly escapes backslashes before quotes, preventing corruption like:
__c("printf(\"Hello \"world\"\n\");");// Corrupted!__c("printf(\"Hello \\\"world\\\"\\n\");");// Correct!Close #141
Summary by Bito
This pull request enhances the inliner tool by fixing string escaping issues and introduces a new tool, norm-lf, to normalize line endings to LF format. These changes improve string processing robustness and ensure consistent line endings across files.