setup: send supplemental params to algorithm_params #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zram-generator used to route secondary compressor parameter blobs to /sys/block/zramX/recompress while setting up the device. The kernel's recompress knob refuses writes until the zram device is initialised (disksize set), so CONFIG_ZRAM_MULTI_COMP setups emitted EINVAL warnings like: Warning: algorithm "zstd" supplemental data "algo=zstd priority=1" not written: Invalid argument Route all supplemental data through /sys/block/zramX/algorithm_params instead, tagging secondary algorithms with their priority. This matches the driver interface, prevents the warning, and still supports primary and secondary parameter payloads. Include unit coverage for the new helper that builds the payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zram-generator used to route secondary compressor parameter blobs to /sys/block/zramX/recompress while setting up the device. The kernel's recompress knob refuses writes until the zram device is initialised (disksize set), so CONFIG_ZRAM_MULTI_COMP setups emitted EINVAL warnings like:
Warning: algorithm "zstd" supplemental data "algo=zstd priority=1" not written: Invalid argument
Route all supplemental data through /sys/block/zramX/algorithm_params instead, tagging secondary algorithms with their priority. This matches the driver interface, prevents the warning, and still supports primary and secondary parameter payloads. Include unit coverage for the new helper that builds the payload.