Add rspec and some basic tests#27
Merged
systemed merged 3 commits intosystemed:masterfrom Nov 28, 2025
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds rspec, along with two very basic tests (i.e. the shortest valid stylesheet, and the basic stylesheet used in the README). This PR also ensures that rspec is run using Github actions.
It also adds the rubocop-rspec plugin, which I find very useful when writing specs.
This isn't intended to be a comprehensive test suite, more just something to catch any subtle coding mistakes during PR reviews. I can see us adding more tests in future to cover certain edge cases or new features, or if we're refactoring something specific. Also, I can also see us rethinking the way we handle source and target stylesheets, perhaps taking inspiration from the carto test suite for full stylesheet input and output. But for now I think this PR is sufficient to get started.