Skip to content

Lock image before sending to clients to ensure image integrity #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OldUser101 merged 3 commits into from
Nov 15, 2025
Merged

Lock image before sending to clients to ensure image integrity #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5c93d4
lock image file before sending to ensure full image is sent
OldUser101 Nov 15, 2025
f3381db
ensure file is valid before releasing lock
OldUser101 Nov 15, 2025
fac5037
fix syntax issue in `run/__init__.py`
OldUser101 Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion shepherd/blueprints/run/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import json
import os
import sys
from fcntl import lockf, LOCK_EX, LOCK_UN
from enum import Enum

from flask import Blueprint, redirect, url_for, request, session, send_file
Expand Down Expand Up @@ -51,7 +52,14 @@ def toggle_auto_refresh():

@blueprint.route("/picture")
def get_picture():
return send_file("/home/pi/shepherd/shepherd/static/image.jpg", mimetype="image/jpeg")
try:
f = os.open("/home/pi/shepherd/shepherd/static/image.jpg", os.O_RDWR)
lockf(f, LOCK_EX)
return send_file("/home/pi/shepherd/shepherd/static/image.jpg", mimetype="image/jpeg")
finally:
if "f" in locals():
lockf(f, LOCK_UN)
os.close(f)

@blueprint.route("/start", methods=["POST"])
def start():
Expand Down
Loading