Proposal: Changing some linting rules, making some fixes #8295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobelenus
requested review from
jkeiser,
vbustamante,
wendybujalski and
zacharyhamm
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
jkeiser
reviewed
Jan 16, 2026
| if (connected) wsConnections.value[workspaceId] = connected; | ||
|
|
||
| await db.setConnections({ ..._wsConnections.value }); | ||
| db.setConnections({ ..._wsConnections.value }); |
Contributor
There was a problem hiding this comment.
I like that we don't await non-async things! Is this enforced by require-await? Seems like a hidden feature of that rule.
zacharyhamm
reviewed
Jan 16, 2026
|
|
||
| // warning on this because we have some shenanigans where it is a promise but a literal `await` is not present | ||
| "@typescript-eslint/require-await": "warn", | ||
| "@typescript-eslint/require-await": 0, |
Contributor
There was a problem hiding this comment.
This change is the only one I'm curious about. We don't want this to be "error" (2)?
Contributor
Author
There was a problem hiding this comment.
Both in the pinia stores, and in the web worker ... basically, we know that with Comlink, things return a promise, so its an async function, even if there isn't an await inside of it... and the same goes to the pinia store... there isn't an await, but the funcs have to be async for the plugin that we wrote to work
jobelenus
force-pushed
the
jobelenus/linting-rules
branch
from
93f7648 to
e564b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for some linting rule fixes—DISCUSS.
This basically leave one rule in warning state that is giving useful feedback to us while making decisions
@typescript-eslint/restrict-template-expressions