Remove deprecated curl_close#127
Merged
jensschuppe merged 2 commits intosystopia:masterfrom Feb 3, 2026
Merged
Conversation
colemanw
commented
Jan 21, 2026
Civi/Twingle/Shop/ApiCall.php
Outdated
| @@ -264,6 +262,5 @@ public function getinfo($ch, $option) { | |||
| } | |||
|
|
|||
| public function close($ch) { | |||
Contributor
Author
There was a problem hiding this comment.
As a followup to this PR, this function could be removed.
Collaborator
|
@MarcMichalsky this affects the twingle shop code, would you have a look? |
Contributor
|
Well, the info.xml file states that this extension is compatible with CiviCRM version |
Collaborator
|
We're currently preparing compatibility checks with newer PHP versions, so this will be fixed in the process. I'm just wondering why PHPStan hasn't reported the deprecation for 8.0 and 8.1 already ... 🤔 |
Contributor
Author
|
I think PHP was late to officially deprecate it. As of 8.0 it does nothing and is "not recommended" but it's not officially deprecated until 8.5. |
This function is deprecated as of php 8.0 and does nothing. See https://www.php.net/manual/en/function.curl-close.php
This function is deprecated as of php 8.0 and does nothing. See https://www.php.net/manual/en/function.curl-close.php
jensschuppe
force-pushed
the
curl_close
branch
from
5dd8362 to
47fd0a8
Compare
jensschuppe
added
bug
jensschuppe
added
status:fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
curl_close()is deprecated; as of php 8.0 it does nothing.See https://www.php.net/manual/en/function.curl-close.php