[pull] master from thrasher-corp:master#102
Merged
pull[bot] merged 1 commit intosyther-labs:masterfrom Feb 9, 2026
Merged
Conversation
…n websocket (#2109) * feat: Enhance websocket management and subscription handling for OKX exchange - Implemented connection management for business websocket channels. - Refactored subscription methods to accept connection parameters. - Added error handling for subscription generation and flushing channels. - Improved websocket connection setup with dedicated methods for public, private, and business connections. - Updated tests to reflect changes in subscription handling and connection management. - Introduced chunking for subscription requests to manage byte limits effectively. - Enhanced error handling in websocket data processing and subscription management. * okx: re-integrate test for business * Update exchange/websocket/manager.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchanges/okx/okx_business_websocket.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update exchanges/okx/okx_websocket.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * glorious: nits, fix test and linter * glorious: slice usage * glorious: test coverage * linter: fix * spelling: kween * revert waitgroup Go func call as its producing some raceyness which I don't want to tackle right now * glorious: patch * Enhance websocket connection management with rate limiting support - Added ConnectionRateLimit function to ConnectionSetup for dynamic rate limiting. - Updated getConnectionFromSetup to utilize ConnectionRateLimit if defined. - Adjusted websocket request handling to use websocketRequestEPL for consistency. - Modified OKX exchange setup to implement specific rate limits for websocket connections. * rm loggig * bossking: nits * Update exchange/websocket/connection.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchange/websocket/manager.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * gk: nits v1 * gk: Add subscription store management to websocket connections * gk: rename connectionWrapper to websocket * rename wrapper var to ws where needed * Update exchange/websocket/connection.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * Update exchange/websocket/connection.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * gk: nits * Update exchange/websocket/manager.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchange/websocket/connection_test.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchange/websocket/connection_test.go Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com> * gk: nits * glorious: nits * glorious: nits * misc: fix * Update exchange/websocket/subscriptions.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchange/websocket/subscriptions.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * Update exchange/websocket/subscriptions.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * glorious: nits * fix intermittent test panic when routine calls GetURL() on fixture connection * fix: shutdown error: nil pointer: *websocket.Conn issue: #2142 * Update exchange/websocket/manager_test.go Co-authored-by: Scott <gloriousCode@users.noreply.github.com> * feat: implement spot margin subscription evaluator and related functionality * fix: re-thread context after merge + linter fix * Dazi: fix panic when zero pair is supplied * test: fix block and error logs when testing business channel subscriptions * glorious: nits * glorious: nits increase time for assert.Eventually tick --------- Co-authored-by: Ryan O'Hara-Reid <ryan.oharareid@thrasher.io> Co-authored-by: Scott <gloriousCode@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Gareth Kirwan <gbjkirwan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )